Drop dependency on rdfc? CommonJS dependency causes optimisation bailouts.

swimlane / ngx-charts

:bar_chart: Declarative Charting Framework for Angular

https://swimlane.github.io/ngx-charts/

MIT License

4.28k stars 1.15k forks source link

Drop dependency on rdfc? CommonJS dependency causes optimisation bailouts. #1901

Open bonyjose opened 9 months ago

bonyjose commented 9 months ago

Describe the bug Warning: @swimlane\ngx-charts\fesm2020\swimlane-ngx-charts.mjs depends on 'rfdc'. CommonJS or AMD dependencies can cause optimization bailouts.

To Reproduce Steps to reproduce the behavior:

run the app that uses 'swimlane-ngx-charts', gets above warning at compile time.

Expected behavior should compile without warning, potential missing optimisation.

Screenshots

ngx-charts version 20.4.1

blogcraft commented 7 months ago

Same here using Angular 17 and esbuild!

[WARNING] Module 'rfdc' used by 'node_modules/@swimlane/ngx-charts/fesm2020/swimlane-ngx-charts.mjs' is not ESM

CommonJS or AMD dependencies can cause optimization bailouts.
For more information see: https://angular.io/guide/build#configuring-commonjs-dependencies

jeudryWepsys commented 6 months ago

Same here with Angular 17

michaelkarkalis commented 6 months ago

Any updates here? same issue!!

MoritzMeinhardt commented 4 months ago

Same here.

kiwidude68 commented 2 months ago

Thanks @PhilFlash for the work on the pull request - however is someone going to do a build of 21.0 so we can have this fix?

bonyjose commented 2 months ago

@marjan-georgiev Can you please review the linked PR by PhilFlash.