search

swimlane / ngx-charts

:bar_chart: Declarative Charting Framework for Angular
https://swimlane.github.io/ngx-charts/
MIT License
4.3k stars 1.15k forks source link

Feature Request: Create separate library for InjectionService #313

Open isaacplmann opened 7 years ago

isaacplmann commented 7 years ago

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here

I'm planning to use your InjectionService and InjectionRegistry in my angular2-contextmenu library. I can easily copy the files over, but I'd prefer to depend on a separate library that will be updated as new versions of Angular come out.

Would you consider splitting those two services out into their own npm package? I'd be happy to do the initial leg work setting it up, if you'll actually use it in your libraries and maintain it going forward.

marjan-georgiev commented 7 years ago

We've come across an issue regarding this recently, and discussed doing just that. Going to work on that soon.

isaacplmann commented 7 years ago

Good to hear. Thanks!