search

swimlane / ngx-charts

:bar_chart: Declarative Charting Framework for Angular
https://swimlane.github.io/ngx-charts/
MIT License
4.29k stars 1.15k forks source link

Incompatibility with Angular 4.4.3 (ngo) and ngx-charts? #583

Open lincolnthree opened 6 years ago

lincolnthree commented 6 years ago

I'm submitting a ... (check one with "x")

[ x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior When doing a Prod AOT build with the new angular NGO optimizer, ngx-charts seems to fail to resolve some of its dependencies for tooltips:

ERROR Error: Uncaught (in promise): TypeError: r is not a function
TypeError: r is not a function
    at Object../src/common/tooltip/injection.service.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/tooltip.service.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/tooltip.directive.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/tooltip.module.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/index.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/injection.service.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/tooltip.service.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/tooltip.directive.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/tooltip.module.ts (0.js:1)
    at e (0.js:1)
    at Object../src/common/tooltip/index.ts (0.js:1)
    at e (0.js:1)
    at c (polyfills.js:3)
    at Object.reject (polyfills.js:3)
    at e._fireError (vendor.js:1)
    at e._failed (vendor.js:1)
    at vendor.js:1
    at t.invoke (polyfills.js:3)
    at Object.onInvoke (vendor.js:1)
    at t.invoke (polyfills.js:3)
    at r.run (polyfills.js:3)
    at polyfills.js:3
b @ vendor.js:1

Expected behavior I'd expect it to work :)

Reproduction of the problem

Please tell us about your environment: Cordova 7 Ionic 3.7.1

lincolnthree commented 6 years ago

Any help would be super appreciated. I'm really at a loss to why this would happen :(

lincolnthree commented 6 years ago

Here is the sample project from that issue that reproduces this with ngx-datadable:

https://github.com/mburger81/ionic-datatable

ross-nordstrom commented 6 years ago

Same here, although I'm just upgrading my project to use AoT so I can't really provide any before/after insights

yurik94 commented 6 years ago

Any news?

theunreal commented 6 years ago

Same here. annoying