`emptyMessage` has wrong rule

swimlane / ngx-datatable

✨ A feature-rich yet lightweight data-table crafted for Angular

http://swimlane.github.io/ngx-datatable/

MIT License

4.63k stars 1.68k forks source link

`emptyMessage` has wrong rule #1170

Open kopach opened 6 years ago

kopach commented 6 years ago

https://github.com/swimlane/ngx-datatable/blob/b02b20e244c402bb29603bddfde707ac7a453939/src/components/body/body.component.ts#L82

based on statement above - emptyMessage won't be shown in case if loadingIndicator option enabled. It should rather not be shown in case if loading still in progress. Otherwise, if I want to have loading indicator enabled and if there will be no data in table after loading finish - message won't be shown

Yogeshwar1992 commented 6 years ago

having same issue any fix?

miheevz commented 6 years ago

same here

appagg commented 5 years ago

It's due to this change: https://github.com/swimlane/ngx-datatable/issues/1138