swimlane / ngx-datatable

✨ A feature-rich yet lightweight data-table crafted for Angular
http://swimlane.github.io/ngx-datatable/
MIT License
4.63k stars 1.68k forks source link

Any plan for Angular 9 Update ? #1824

Closed kamlesh0606 closed 4 years ago

kamlesh0606 commented 4 years ago

Current behavior

Expected behavior

Reproduction of the problem

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

blondie63 commented 4 years ago

I've used until Angular 9.0.2 but with v9.0.4 KO !!

marcio199226 commented 4 years ago

For me it's working on 9.0.5

Angular CLI: 9.0.5
Node: 12.16.1
OS: linux x64

Angular: 9.0.5
... animations, cli, common, compiler, compiler-cli, core
... elements, forms, language-service, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.900.5
@angular-devkit/build-angular      0.900.5
@angular-devkit/build-optimizer    0.900.5
@angular-devkit/build-webpack      0.900.5
@angular-devkit/core               9.0.5
@angular-devkit/schematics         9.0.5
@angular/cdk                       9.1.1
@angular/flex-layout               9.0.0-beta.29
@angular/http                      7.2.7
@angular/material                  9.1.1
@angular/material-moment-adapter   9.1.1
@ngtools/webpack                   9.0.5
@schematics/angular                9.0.5
@schematics/update                 0.900.5
rxjs                               6.5.4
typescript                         3.7.5
webpack                            4.41.2
blondie63 commented 4 years ago

For me it's working on 9.0.5

Angular CLI: 9.0.5
Node: 12.16.1
OS: linux x64

Angular: 9.0.5
... animations, cli, common, compiler, compiler-cli, core
... elements, forms, language-service, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.900.5
@angular-devkit/build-angular      0.900.5
@angular-devkit/build-optimizer    0.900.5
@angular-devkit/build-webpack      0.900.5
@angular-devkit/core               9.0.5
@angular-devkit/schematics         9.0.5
@angular/cdk                       9.1.1
@angular/flex-layout               9.0.0-beta.29
@angular/http                      7.2.7
@angular/material                  9.1.1
@angular/material-moment-adapter   9.1.1
@ngtools/webpack                   9.0.5
@schematics/angular                9.0.5
@schematics/update                 0.900.5
rxjs                               6.5.4
typescript                         3.7.5
webpack                            4.41.2

I've tried with angular 9.0.6 and it works ! There are only the same warnings: npm WARN @swimlane/ngx-datatable@16.0.3 requires a peer of @angular/common@<9.0.0 but none is installed. You must install peer dependencies yourself. npm WARN @swimlane/ngx-datatable@16.0.3 requires a peer of @angular/core@<9.0.0 but none is installed. You must install peer dependencies yourself. npm WARN @swimlane/ngx-datatable@16.0.3 requires a peer of @angular/platform-browser@<9.0.0 but none is installed. You must install peer dependencies yourself.

I hope they release a new ngx-datatable.. :)

jacobsome commented 4 years ago

I am getting the error as below when the angular is updated to 9.0.6. I have used latest version of swimlane/ngx-datatable, Hopefully expecting the release.

ERROR in node_modules/ng2-completer/src/directives/ctr-row.d.ts:1:22 - error TS2724: Module '"../../../@angular/core/core"' has no exported member 'Renderer'. Did you mean 'Renderer2'?

1 import { ElementRef, Renderer, OnDestroy } from "@angular/core";


  node_modules/@angular/core/core.d.ts:5701:31
    5701 export declare abstract class Renderer2 {
'Renderer2' is declared here.
blondie63 commented 4 years ago

with la Angular 9.1.0 ngx-datatable KO with enableIvy = false !! many errors :( someone know some new updated datatable ?

KBeDevel commented 4 years ago

For now, with Angular 9.1.0 with enableIvy = true, compiles without problems

Hypercubed commented 4 years ago

Yes, should work as is. An update with explicit support for ng9 is coming.