Open elliotstoner opened 3 years ago
@elliotstoner I tried to reproduce it with that exact same version of Chrome and was not able to.
@joeveiga instead of clicking and dragging left/right after the text is highlighted, are you able to reproduce it if you drag down (like in my recording)?
@elliotstoner Nope, I tried to reproduce it as close to your recording as possible and still working fine. One odd thing I noticed is that, when you're first selecting the text, the columns didn't move at all. Even though you're dragging down, there should be some horizontal movement as well (unless you have some godlike wrist control lol 🤣 )
@joeveiga I did notice that as well... definitely don't have godlike wrist control lol, I wasn't sure if that was expected or not? I wonder if it has to do with the OS (MacOS BigSur 11.0.1) and not the browser? Or the fact I'm using a trackpad?
I'm submitting a ... (check one with "x")
Current behavior When resizing a column when text is highlighted, the column continues to resize after the user lets go of the mouse button.
Expected behavior When resizing a column, the column should stop resizing when the user lets go of the mouse button.
Reproduction of the problem Can be reproduced by using the table located at http://swimlane.github.io/ngx-datatable/ (these STRs use the table there)
What is the motivation / use case for changing the behavior?
Please tell us about your environment: Whatever the environment used for the example site.
Table version: 18.0.0
Angular version: Tested in Angular 9 and 10
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ] Used Chrome Version 87.0.4280.88 (Official Build) (x86_64) on Mac OS.
Language: [all | TypeScript X.X | ES6/7 | ES5] all
I've attached a screen recording of this behavior happening with the steps to reproduce. It looks the user is highlighting text, which happens to include the vertical bar that the user would also uses to resize the column. Then when they click and drag that horizontal bar, the browser/OS recognizes that the user has highlighted text under the cursor, so it tries to copy/drag the text to wherever the user is going. When the user lets go, my assumption is the browser/OS swallows the "keyup" event, so ngx-datatable can't use that event to stop resizing (it still thinks the user has the mouse button down) (that of course is a very basic assumption, it could be one of many things). Screen Recording 2020-12-11 at 2.12.51 PM.mov.zip