swimlane / ngx-datatable

✨ A feature-rich yet lightweight data-table crafted for Angular
http://swimlane.github.io/ngx-datatable/
MIT License
4.63k stars 1.68k forks source link

Requesting upgrade of rxjs version #2073

Open leifjones opened 2 years ago

leifjones commented 2 years ago

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

When upgrading rxjs to 7.4+ (as is supported by Angular 13) via the command ng update rxjs, we see output of Package "@swimlane/ngx-datatable" has an incompatible peer dependency to "rxjs" (requires "^6.6.3", would install "7.5.4").

Expected behavior

No such warning requiring the command ng update rxjs --force to be run instead.

Reproduction of the problem N/A

What is the motivation / use case for changing the behavior? Support newly-created Angular 13 projects.

Please tell us about your environment: Windows 11, VS Code, npm 7 / npm 8

kichus14 commented 2 years ago

+1

christophercr commented 2 years ago

I've submitted this PR #2108, hopefully that will unblock us to move forward with Angular 13 + Ivy.

leifjones commented 1 year ago

For anyone waiting on this, or similar, note that a parallel package is: @siemens/ngx-datatable