search

swimlane / ngx-dnd

🕶 Drag, Drop and Sorting Library for Angular2 and beyond!
https://swimlane.github.io/ngx-dnd/
MIT License
574 stars 136 forks source link

Angular9 support #154

Closed hijamoya closed 4 years ago

hijamoya commented 4 years ago 
ERROR in Failed to compile entry-point @swimlane/ngx-dnd (es2015 as esm2015) due to compilation errors:
node_modules/@swimlane/ngx-dnd/fesm2015/swimlane-ngx-dnd.js:767:33 - error NG1006: Cannot combine @Input decorators with query decorators
node_modules/@swimlane/ngx-dnd/fesm2015/swimlane-ngx-dnd.js:958:31 - error NG6001: The class 'ContainerComponent' is listed in the declarations of the NgModule 'NgxDnDModule', but is not a directive, a component, or a pipe.

Please upgrade to support angular9 app.

yakimko commented 4 years ago

@Hypercubed any updates on this?

jlbates commented 4 years ago

For what it's worth, you can quite easily replace this library with the @angular/cdk/drag-drop library for angular 9 support.

edit: For the simple drag and drop list scenario =)

yakimko commented 4 years ago

@jlbates it does not support nested components

Hypercubed commented 4 years ago

We've been using ngx-dnd with ng9 for sometime. Can you verify you have installed latest?

hijamoya commented 4 years ago

I saw this commit: https://github.com/swimlane/ngx-dnd/commit/dcb5990388dbd5867bd14cf1202a1637f424367b But there is no corresponding release for it.

Hypercubed commented 4 years ago

The specific issue reported was fixed here: https://github.com/swimlane/ngx-dnd/pull/151 and released in v8.1. Please make sure you have ngx-dnd@v8.1 installed.

ozeltser commented 4 years ago

I have this crash happening with "@swimlane/ngx-dnd": "^8.1.0", in my package.json Error: Failed to compile entry-point @swimlane/ngx-dnd (esm5 as esm5) due to compilation errors: node_modules/@swimlane/ngx-dnd/esm5/lib/ngx-dnd.module.js:36:35 - error NG1010: Expected array when reading the NgModule.declarations of NgxDnDModule

36 declarations: tslib_1.__spread(components, directives),

kishorpawar commented 4 years ago

For me I got the following warning before compilation start, but compilation still succeed without any error.

Warning: Entry point '@swimlane/ngx-dnd' contains deep imports into '../node_modules/@angular/compiler/src/core'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

Hypercubed commented 4 years ago

The deep imports warning has been fixed.