swimlane / ngx-dnd

🕶 Drag, Drop and Sorting Library for Angular2 and beyond!
https://swimlane.github.io/ngx-dnd/
MIT License
575 stars 135 forks source link

Resolve Angular Ivy deep link warning #161

Closed SamuelMS closed 4 years ago

SamuelMS commented 4 years ago

What kind of change does this PR introduce? (check one with "x")

What is the current behavior? (You can also link to an open issue here)

Warning during compilation with Angular Ivy:

Warning: Entry point '@swimlane/ngx-dnd' contains deep imports into '/Users/samuelms/Documents/GitHub/datamonkey-frontend/node_modules/@angular/compiler/src/core'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

See #160.

What is the new behavior?

No warning during compilation.

Does this PR introduce a breaking change? (check one with "x")

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@Hypercubed Very minor change to imports to resolve a warning during Angular Ivy compilation.

SamuelMS commented 4 years ago

@Hypercubed Hey, just want to make sure this didn't slip past your radar. Let me know if anything needs to change.

Hypercubed commented 4 years ago

@SamuelMS Wasn't this fixed in the latest patch of Angular?

SamuelMS commented 4 years ago

@Hypercubed I don't think so – unless you mean Angular 10, which is still in RC. We're running 9.1.9 and still seeing this.

Hypercubed commented 4 years ago

@SamuelMS Please try v8.1.2

SamuelMS commented 4 years ago

LGTM, thanks.