search

swimlane / ngx-dnd

🕶 Drag, Drop and Sorting Library for Angular2 and beyond!
https://swimlane.github.io/ngx-dnd/
MIT License
575 stars 135 forks source link

SPT-12291 Revert Angular 13 Updates #210

Closed ischultz closed 2 years ago

ischultz commented 2 years ago

What kind of change does this PR introduce? (check one with "x")

What is the current behavior? (You can also link to an open issue here) The project was previously updated to Angular 13 and converted to use ESLint

What is the new behavior? Reverted Angular 13 and ESLint changes so that a release could be made with the existing version of Angular but with the vulnerability updates. Also switched away from node-sass to sass to resolve a vulnerability and due to node-sass being deprecated.

Does this PR introduce a breaking change? (check one with "x")

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

ischultz commented 2 years ago

After further discussion, we will not revert these changes.

bahizi commented 2 years ago

@ischultz do you know when the angular 13 upgrade changes will be released to npm?

ischultz commented 2 years ago

@bahizi I unfortunately cannot provide you with an estimated time frame but please know that we are working on it!

Hypercubed commented 2 years ago

@bahizi What issue are you having with the current release. It does work in Angular 13.

bahizi commented 2 years ago

@Hypercubed oh yeah it works with no issues once built and deployed. it's just that I have some automated dependency management tools monitoring my repo and they don't seem to like that per @swimlane/ngx-dnd's package.json angular 13 is not supported. Also npm@7+ is rather more strict about missing dependencies and without the --legacy-peer-deps flag it makes ci installs/builds fail if a certain package's dependency is missing.