search

swimlane / ngx-graph

Graph visualization library for angular
https://swimlane.github.io/ngx-graph
MIT License
922 stars 285 forks source link

Chore/update angular to 17 #543

Open Kr0san89 opened 4 months ago

Kr0san89 commented 4 months ago

What kind of change does this PR introduce? (check one with "x")

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? new angular version

Does this PR introduce a breaking change? (check one with "x")

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... only angular 17 the documentation system has some issues (need updates there too)

Other information:

DeepakGMTT commented 2 weeks ago

hi @marjan-georgiev i'm using this package for my project can we please priority this PR. Can we have the time line when this PR will be merged?

mayurmuley1412 commented 2 weeks ago

hi @marjan-georgiev i'm using this package for my project can we please priority this PR. Can we have the time line when this PR will be merged?

I am also waiting for the merge and release. @Kr0san89 Can you check conflicts and merge this PR since its approved.

Kr0san89 commented 2 weeks ago

hi @marjan-georgiev i'm using this package for my project can we please priority this PR. Can we have the time line when this PR will be merged?

I am also waiting for the merge and release. @Kr0san89 Can you check conflicts and merge this PR since its approved.

Sadly i can not the approvement has to come from a person with "write access" which is not the case yet. It is not even clear if they want to merge this PR at some stage. As i have another PR open for over a year https://github.com/swimlane/ngx-graph/pull/513 i got a bit more carefull how i invest my time here.

If there is a comment from someone who can merge that they will i would do it, but until then i'll wait.

But this PR will not bring you much benefit other than "smaller bundle"