search

swimlane / systemjs-route-bundler

SystemJS Route-Driven Bundler
MIT License
41 stars 8 forks source link

Process Hangs on Windows Machines. #26

Closed cliechty closed 9 years ago

cliechty commented 9 years ago

When I try to bundle routes (testing with systemjs-seed project) the bundler hangs and the node process is pegging the CPU. On my mac the bundler processes fine and fairly quickly.

The output I get on a windows machine when it hangs is:

[13:54:51] Running as: development
[13:54:57] Using gulpfile C:\code\js\systemjs-seed\gulpfile.js
[13:54:57] Starting 'routeBundler'...
tracing source files...
generating bundles...
building...
building bundles...
building routes...
building app...
To replicate:
  1. clone project: https://github.com/lookfirst/systemjs-seed
  2. run npm install
  3. run jspm install
  4. run gulp recompile
  5. run gulp routerBundler

I have verified that the issue exists with node 0.10.x and 0.12.x. It looks almost like the process is getting stuck in an infinite loop on windows machines.

My Windows config is:

lookfirst commented 9 years ago

JavaScript... Write once, run almost anywhere! :wink:

lookfirst commented 9 years ago

I'm working today on upgrading to latest of this project...

cliechty commented 9 years ago

I found out what is causing the issue on windows. Turns out that builder is writing the files from npm, github, etc into the 'dest' folder, prefixing them with the repo:packagename ex: npm:react@0.13.1.js. In windows ':' is not a valid character in a file or directory name.

As a side note; shouldn't all of the referenced files be bundled?

marjan-georgiev commented 9 years ago

@cliechty thank you for catching that!

Those files are currently bundled, but also built separately (which is unnecessary). I'll push a fix for this today.

amcdnl commented 9 years ago

@cliechty don't use windows ;)

lookfirst commented 9 years ago

Oh yea, I noticed all those folders getting created in my dest folder. Would be nice to not have those. =)

:+1: on not using windows!

cliechty commented 9 years ago

Unfortunately those who pay my salary force me to use windows. :frowning:

lookfirst commented 9 years ago

I think I'd bring my own computer to work then. ;-)

marjan-georgiev commented 9 years ago

I pushed a fix. Please upgrade your project to use 1.1.1

cliechty commented 9 years ago

I have confirmed the issue is fixed. Thanks for the quick turnaround. This project looks like it will really help my teams project in the near future.