* Added cookbook for downlink between servers

swimos / cookbook

Cookbook code snippets, gathered into runnable Gradle projects.

Apache License 2.0

16 stars 8 forks source link

* Added cookbook for downlink between servers #10

Closed PiggottDev closed 3 years ago

PiggottDev commented 3 years ago

Added a cookbook where a downlink is used between two servers.

A JoinMapLane is also created where the downlinks are on a separate server.

ajay-gov commented 3 years ago

Will be good to showcase these 4 scenarios

Downlink to a ValueLane in plane 1 from plane 2 using plane 2's context
Downlink to a MapLane in plane 1 from plane 2 using plane 2's context
Downlink to a ValueLane in plane 1 from an agent in plane 2 using the agent's context
Downlink to a MapLane in plane 1 from an agent in plane 2 using the agent's context

PiggottDev commented 3 years ago

Resolved all of Dobromir's comments and added each scenario mentioned by Ajay

ajay-gov commented 3 years ago

@PiggottDev looks good! Couple of minor fixes and then it should be good to merge.

It's hard to see where the log messages for the downlink callbacks are getting invoked i.e from the Plane or from the Agent. It might be good to make that explicit in the log messages. In general I think it is good to prefix the nodeUri() in the Agent log messages. So something like: System.out.println(nodeUri() + ": .....")

The Readme title still says JoinLanes,

PiggottDev commented 3 years ago

@ajay-gov Thanks - I've made the logging better and fixed the Readme title

ajay-gov commented 3 years ago

I'm ok if this gets merged into master if @DobromirM approves