Closed nakedible-p closed 1 hour ago
@nakedible-p the last release did actually implement Extension for Option which superseded the NegotiatedExtension system, however, I didn't add one for the ExtensionProvider. I'll get this added for the next release
This is unrelated, but two other issues quickly:
ratchet_core::server::handshake
takes in &ExtensionProvider
, but ratchet_core::server::response_from_headers
takes in ExtensionProvider
. Doesn't make a difference, but I don't think this is intentional.handshake
nor response_from_headers
returns the selected subprotocol, forcing the user to either look into the returned header manually, or to use parse_request_parts
and build_response_headers
manually.@nakedible-p I'll get that fixed in the next release too
We need to be able to disable compression at runtime, based on a flag. Meaning that even if the client proposes to use deflate, the server will not support that extension. How we solved that outside of Ratchet was simply:
But Ratchet could implement it directly for
Option<T>
.Just a suggestion though, might be too obscure.