swimos / swimos-docs

Documentation for SwimOS
Apache License 2.0
0 stars 3 forks source link

WIP: Fix navbar on blog pages #197

Closed afolson closed 7 months ago

netlify[bot] commented 7 months ago

Deploy Preview for scintillating-strudel-60ff56 ready!

Name Link
Latest commit 3d93e4d3ac5aac412995ae7071442dcba063cec8
Latest deploy log https://app.netlify.com/sites/scintillating-strudel-60ff56/deploys/6605e447b39d020008af4406
Deploy Preview https://deploy-preview-197--scintillating-strudel-60ff56.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

afolson commented 7 months ago

@cwjames19 Are you able to take a look at this one? On the live site, the menu pops over blog posts (it works as intended on other pages): https://www.swimos.org/blog/2024/1/16/fine-grained-streaming-apis-from-a-kafka-topic.html

I fixed some things in the header (references to colors we aren't using) but I'm now not able to get the menu to render on blog post pages:

Screenshot 2024-03-25 at 4 56 55 PM

I think this has something to do with Alpine.js and x-open/x-cloak but I couldn't figure out what the exact issue is. It seems like open: true is being set somehow but the menu isn't actually rendering. I can get other stuff to appear consistently when open: true is set, I just can't get the menu to work. It didn't seem to be a priority thing either. Thanks!

cwjames19 commented 7 months ago

@afolson No problem! I'll take a look.

cwjames19 commented 7 months ago

@afolson Figured it out. Took a while but it turned out the Alpine.js scripts just weren't being loaded on the blog pages so I moved them from footer-scripts.html to head.html. If it looks good to you, feel free to merge.

afolson commented 7 months ago

@cwjames19 Thanks a ton!