swimuel / reelio

0 stars 0 forks source link

[FEATURE](high): End point for retrieving movie information #22

Closed KelseyRM closed 5 years ago

KelseyRM commented 5 years ago

User Story:

7

Describe Task:

Acceptance Criteria:

emipeanz commented 5 years ago

Look in code base, there is an API file that just calls it. Not like Angular where you can inject things. React doesnt restrict what access you have

swimuel commented 5 years ago

@KelseyRM saw you moved this from sprint backlog to product backlog, are we no longer doing it in this sprint?

swimuel commented 5 years ago

this query http://www.omdbapi.com/?apikey=8d8a7ec2&t=Avengers returns: { "Title": "The Avengers", "Year": "2012", "Rated": "PG-13", "Released": "04 May 2012", "Runtime": "143 min", "Genre": "Action, Adventure, Sci-Fi", "Director": "Joss Whedon", "Writer": "Joss Whedon (screenplay), Zak Penn (story), Joss Whedon (story)", "Actors": "Robert Downey Jr., Chris Evans, Mark Ruffalo, Chris Hemsworth", "Plot": "Earth's mightiest heroes must come together and learn to fight as a team if they are going to stop the mischievous Loki and his alien army from enslaving humanity.", "Language": "English, Russian, Hindi", "Country": "USA", "Awards": "Nominated for 1 Oscar. Another 38 wins & 79 nominations.", "Poster": "https://m.media-amazon.com/images/M/MV5BNDYxNjQyMjAtNTdiOS00NGYwLWFmNTAtNThmYjU5ZGI2YTI1XkEyXkFqcGdeQXVyMTMxODk2OTU@._V1_SX300.jpg", "Ratings": [ { "Source": "Internet Movie Database", "Value": "8.1/10" }, { "Source": "Rotten Tomatoes", "Value": "92%" }, { "Source": "Metacritic", "Value": "69/100" } ], "Metascore": "69", "imdbRating": "8.1", "imdbVotes": "1,191,030", "imdbID": "tt0848228", "Type": "movie", "DVD": "25 Sep 2012", "BoxOffice": "$623,279,547", "Production": "Walt Disney Pictures", "Website": "http://marvel.com/avengers_movie", "Response": "True" }

emipeanz commented 5 years ago

So as per discussion with @darcycox97 and @cyrus-raitava we're gonna make a wrapper file ie. endpoint that will deal with everything to do with OMDB. This means for front end people @lucyJiang279 you will have to call our API endpoint (just a bunch of functions) and hand in the film id to get relevant informaiton. This should make it easier and cleaner from your end 😄

emipeanz commented 5 years ago

Adding a table of services and port numbers to wiki cause running into issues with them here

emipeanz commented 5 years ago

Whoever is doing #45, you'll need to do pre-processing of the search parameter and replace any spaces with '+'. You'll also need to make a check to see if the user hasnt typed in a second, then send an API call, otherwise we'll be sending API calls every keypress and we dont want to do that

emipeanz commented 5 years ago

Tested by Product Owner Sprint Review 2