search

swingerman / lovelace-fluid-level-background-card

This card wraps any other cards and renders a fluid background behind them.
MIT License
41 stars 8 forks source link

Fix bug caused by renaming #483

Open Segilmez06 opened 5 days ago

Segilmez06 commented 5 days ago

Hey there! First of all, thanks for this amazing project. I have been using it for some time now. But here is a small problem. Everytime I do any interaction with mouse, the card seems to re-render itself. And strangely, this problem only occurs when the window is maximized (IDK if it's related).

I did some small research and found a renaming typo. It's on commit swingerman/lovelace-fluid-level-background-card@137da7bffd71ac1be5af40d725eefc5d4c5ad394 and merged to main with #11. While renaming action-handler-fluid-progressbar to action-handler-fluid-progressbar, line that checks if action handler exists mistakenly checks for action-handler-sbar. This causes the code to append hundreds of action handler elements to document body. I tried changing the code on my HASS instance and it fixed the problem. And this small PR, I just fixed that naming.

Here is a video of the bug caused by the typo:

https://github.com/user-attachments/assets/8787d1cb-c85a-4301-a392-786cdb486844

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud