search

swingmx / swingmusic

Swing Music is a beautiful, self-hosted music player for your local audio files. Like a cooler Spotify ... but bring your own music.
https://swingmx.com
MIT License
678 stars 41 forks source link

Add docker image support #120

Closed Bitnik212 closed 1 year ago

Bitnik212 commented 1 year ago

Features:

cwilvx commented 1 year ago

Hello @Bitnik212 👋

Thank you for this PR. There's another pull request (#116 by @tralph3) which adds a Dockerfile. I'll be merging it soon. I see that you are adding docker-compose support. If you don't mind, can you build on top of the the Dockerfile in #116?

I like what you have done with the screenshots on the readme. it looks so much better now. Thanks.

Bitnik212 commented 1 year ago

Hello @mungai-njoroge

I did not notice that there is a similar pr. I will most likely close this pr.

I can't change my docker-compose examples. Due to the fact that I use my docker image which I posted on hub.docker.com. To modify my examples I need a docker image based on pr (#116 by @tralph3)

cwilvx commented 1 year ago

@Bitnik212 I have merged #116. You can use the new Dockerfile in the repo to build an image for docker-compose.

Bitnik212 commented 1 year ago

@mungai-njoroge, thanks. i create pr #121 with docker compose examples