swingmx / swingmusic

Swing Music is a beautiful, self-hosted music player for your local audio files. Like a cooler Spotify ... but bring your own music.
https://swingmx.com
MIT License
755 stars 41 forks source link

Wrong Getting Started guide #169

Closed tcsenpai closed 8 months ago

tcsenpai commented 8 months ago

The command docker run --name swingmusic -p 1971:1970 \ -v /path/to/music:/music -v /path/to/config:/config \ --restart unless-stopped geoffrey45/swingmusic

should be

docker run --name swingmusic -p 1971:1970 \ -v /path/to/music:/music -v /path/to/config:/config \ --restart unless-stopped ghcr.io/swing-opensource/swingmusic

Also, mounting two /music directories errors out

cwilvx commented 8 months ago

Hello @tcsenpai

Thanks for opening this issue. The docs issue has been fixed.

cwilvx commented 8 months ago

@tcsenpai

Can you provide the error produced when you mount two folders to /music? It's hard to know what is happening without some kind of error message.

Thanks.

tcsenpai commented 8 months ago

@cwilvx

Sorry for the lack of informations, was late and I forgot to attach the error output.

I unfortunately lost the original one, and I would need to restart the service to copy paste the exact error.

EDIT: docker, not docker-compose, my bad Anyway, docker complained about mounting multiple folders onto the same path.

If you need a more detailed error, Ill set up a new machine to reproduce it.

A possible solution (but it is on top of my mind so is probably not optimized) is to make /music mountpoint as a link to something like /music_folders/ and provide the user with the option to add its folders as subfolders of the /music_folder/ directory.

If i understood the software logic, everything under /music is recursively scanned

cwilvx commented 8 months ago

@tcsenpai

Alternatively, the user can just mount the folders to others paths, then inside Swing Music, they can add them as root directories in settings. Something like this:

-v /path/to/music: /music
-v /path/to/rock: /rock

Thank you for your suggested approach. I'll look into how I can do that.

tcsenpai commented 8 months ago

Thanks, I close it as both the things are acknowledged