swingmx / swingmusic

Swing Music is a beautiful, self-hosted music player for your local audio files. Like a cooler Spotify ... but bring your own music.
https://swingmx.com
MIT License
718 stars 41 forks source link

Move server code to this repo #95

Closed cwilvx closed 1 year ago

cwilvx commented 1 year ago

This pull request brings server code to this repo (main repo). Related to https://github.com/geoffrey45/alice-core/pull/8

netlify[bot] commented 1 year ago

Deploy Preview for alicemusic failed.

Name Link
Latest commit 1f3d0b6f9381829e15897f2cc05f48569e0e7fb9
Latest deploy log https://app.netlify.com/sites/alicemusic/deploys/63c18d992dda89000aaedd88
gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [2546299](https://dashboard.gitguardian.com/incidents/2546299?occurrence=81989630) | Generic High Entropy Secret | 1f3d0b6f9381829e15897f2cc05f48569e0e7fb9 | app/settings.py | [View secret](https://github.com/geoffrey45/alice/commit/1f3d0b6f9381829e15897f2cc05f48569e0e7fb9#diff-1583acfd980120d1beffb569a94b26ccd42c7311b8d5b0193d009fb5207edb05R38) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!