search

swinton / screenshot-website

:camera_flash: A GitHub Action to capture screenshots of a website, across Windows, Mac, and Linux
https://git.io/screenshot-website
ISC License
187 stars 22 forks source link

GitHub Action fails with OS variables #10

Closed rootwork closed 3 years ago

rootwork commented 3 years ago

Running just the basic usage works.

When I tried using the first advanced usage example, with the different OSes, I got the following errors--

On Windows: Error: Failed to launch the browser process! spawn C:\Program Files (x86)\Google\Chrome\Application\chrome.exe ENOENT

On Mac: Error: The operation was canceled.

On Ubuntu: Error: A task was canceled.

(To be clear, I didn't cancel those myself, and the error doesn't seem to provide any more info on why they were canceled.)

Incidentally, using the width variables with a single OS does work, although the width variable generates a warning. Attempting it with both width and OS variables (as in the second advanced usage example) fails on the same OS errors.

rootwork commented 3 years ago

Oh, the warning on "width" must be for the same reason as #2

swinton commented 3 years ago

Possibly the path to chrome.exe has changed on the Windows hosts. I will take a look.

swinton commented 3 years ago

Should be working again, available on the @v1.x ref.

rootwork commented 3 years ago

Excellent, thanks for the quick fix!