search

swinton / screenshot-website

:camera_flash: A GitHub Action to capture screenshots of a website, across Windows, Mac, and Linux
https://git.io/screenshot-website
ISC License
187 stars 22 forks source link

Warning when using additional parameters #2

Closed metaodi closed 4 years ago

metaodi commented 4 years ago

I'm using this action to create fullscreen screenshots of a website, that loads after some seconds. Therefore I use the delay and full-screen parameter. Since today (example run) there is a warning displayed (as annotation):

Unexpected input 'delay', valid inputs are ['source', 'destination']

I don't know if something changed at GitHub to now detect non-specified arguments.

Is there a way to get rid of the warning?

swinton commented 4 years ago

Hi! That's unfortunate about the warning 🤔

Is there a way to get rid of the warning?

I would happily accept a PR to add the params you need as official inputs to the action, i.e. here:

https://github.com/swinton/screenshot-website/blob/ebee86398fa0b725f4080fd8a016d845211dd279/action.yml#L3-L10

metaodi commented 4 years ago

@swinton thanks, I created PR #3 to add at least my params to avoid these warnings. Maybe there will be a flag in the future to allow arbitrary inputs.

Others have similar issues: https://github.com/octokit/request-action/issues/26

swinton commented 4 years ago

Thanks for the PR! This is now available on the v1.x release branch.

Using that branch should resolve this issue.

metaodi commented 4 years ago

It works, thanks!