Open jcfr opened 1 year ago
Sounds good!
Just curious about the general approach to release strategy here: If the upgrade from node12 to node16 does not introduce breaking changes in screenshot-website, technically we would not have to do a major version upgrade, would we?
As an aside: The [^3]
reference is missing above.
would love to see this updated to most recent version of node with LTS (20, iirc).
@matsonj do you have experience with this type of upgrade, and could you help with this?
Just adding the reference by GitHub about their GitHub Actions transitioning to node 20 now: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
As described in this post^1, node12 is being deprecated in favor of node16:
Reviewing the changelogs of other GitHub Actions like
checkout
[^2] orcache
[^3], the transition to node16 corresponded to a major release.I suggest we follow the same pattern and release
v2
[^2]: https://github.com/actions/checkout/blob/main/CHANGELOG.md#v300 and https://github.com/actions/checkout/commit/8f9e05e482293f862823fcca12d9eddfb3723131 [^2]: https://github.com/actions/cache/blob/main/RELEASES.md#300 and https://github.com/actions/cache/commit/4e817c1f425229b05d28cfabc612297540ebb409