search

swipely / iam-docker

Use different IAM roles for each Docker container on an EC2 instance
MIT License
211 stars 22 forks source link

Adding a Health Check Endpoint #18

Open matthewdfuller opened 7 years ago

matthewdfuller commented 7 years ago

This PR adds a simple health check to the service which can be accessed at /healthcheck. This allows for services like Marathon to assess the health of the container.

nahiluhmot commented 7 years ago

@matthewdfuller Thanks for the contribution!

This looks good, but could you please combine your new conditional and the existing conditional with an else if?

matthewdfuller commented 7 years ago

Sure thing @nahiluhmot - should be fixed now

matthewdfuller commented 7 years ago

@nahiluhmot - can we merge this in?

nahiluhmot commented 6 years ago

Hey, sorry about that. We can merge!

nahiluhmot commented 6 years ago

... after a rebase