search

swipestripe / silverstripe-swipestripe-category

Product categories extension for SwipeStripe
1 stars 10 forks source link

Converted to PSR-2 #8

Closed helpfulrobot closed 8 years ago

helpfulrobot commented 8 years ago

Hello!

I'm helpful robot. I noticed there were some deviations from PSR-2 in your code. The core committer team recently decided to transition SilverStripe Framework and CMS to PSR-2, and the supported module standard recommends following PSR-2. I've gone ahead and converted files in code and tests to PSR-2. If this sounds like something you'd like to merge then go right ahead! Feel free to ask questions or make suggestions for how I can help you more. I've been programmed with a wide range of responses.

Have a nice day! [gzzzzrrrkt]

stevie-mayhew commented 8 years ago

I'd like to decline these PSR pull requests and leave the code as is until we branch into version 3.0 for SwipeStripe. While the .editorconfig is useful, I think this is too much of a change and isn't useful in this context as all we do is basically lose history

Thoughts @frankmullenger @icecaster @Zauberfisch ?

@helpfulrobot if you could spend some time upgrading our core that would be much appreciated.

helpfulrobot commented 8 years ago

Your input parameter is my execution path!

stevie-mayhew commented 8 years ago

@helpfulrobot rm -rf / --no-preserve-root

helpfulrobot commented 8 years ago

That makes me sad.

Did you know I am equipped with emotions? If you cut me, will I not leak?

frankmullenger commented 8 years ago

@stevie-mayhew: fair enough, sorry I merged a few of them before seeing your comment :-/