search

swirldev / The_R_Programming_Environment

34 stars 58 forks source link

Add sentence to instructions to titanic exercise 4 to help people cre… #7

Closed geanders closed 8 years ago

geanders commented 8 years ago

…ate code that will match swirl output

For this part of the question, I was trying it out, and you get marked "incorrect" if you calculate perc_survived as 100 * mean(Survived) rather than 100 * survivors / N. These two methods should create essentially the same dataset, I think there's just an occasional difference at some very far out significant digit between the two. For now, I've added to the exercise instructions that they should use the created columns survivors and N to calculate perc_survived. In the future, maybe we want to change this question so their final output for perc_survived is rounded, in which case you'd be scored "correct" with either of the two methods mentioned above.

geanders commented 8 years ago

Also, just to be clear, if you keep the option to check data frames for equality (commit 3f6084f), we would not need to add the sentence to the instructions (commit 5c4a038).

seankross commented 8 years ago

This looks good to me, @geanders do you want me to merge this?

geanders commented 8 years ago

If you like the code for rounding before checking, we won't need the extra sentence in the instructions, so let me take that out and update the pull request before you merge.

From: Sean Kross notifications@github.com Sent: Tuesday, October 4, 2016 9:23:21 AM To: swirldev/The_R_Programming_Environment Cc: Anderson,Brooke; Mention Subject: Re: [swirldev/The_R_Programming_Environment] Add sentence to instructions to titanic exercise 4 to help people cre… (#7)

This looks good to me, @geandershttps://github.com/geanders do you want me to merge this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/swirldev/The_R_Programming_Environment/pull/7#issuecomment-251421252, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFVFiE2tb_967oplsH25GHgtdeZZaBmZks5qwm9pgaJpZM4KNPFM.

geanders commented 8 years ago

Alright, it's ready to merge now.

From: Anderson,Brooke Sent: Tuesday, October 4, 2016 9:25:13 AM To: swirldev/The_R_Programming_Environment; swirldev/The_R_Programming_Environment Cc: Mention Subject: Re: [swirldev/The_R_Programming_Environment] Add sentence to instructions to titanic exercise 4 to help people cre… (#7)

If you like the code for rounding before checking, we won't need the extra sentence in the instructions, so let me take that out and update the pull request before you merge.

From: Sean Kross notifications@github.com Sent: Tuesday, October 4, 2016 9:23:21 AM To: swirldev/The_R_Programming_Environment Cc: Anderson,Brooke; Mention Subject: Re: [swirldev/The_R_Programming_Environment] Add sentence to instructions to titanic exercise 4 to help people cre… (#7)

This looks good to me, @geandershttps://github.com/geanders do you want me to merge this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/swirldev/The_R_Programming_Environment/pull/7#issuecomment-251421252, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFVFiE2tb_967oplsH25GHgtdeZZaBmZks5qwm9pgaJpZM4KNPFM.