search

swirldev / swirlify

:books: A toolbox for writing swirl courses
Other
63 stars 47 forks source link

Reserved words in answers #21

Closed elinw closed 8 years ago

elinw commented 8 years ago

Hi,

In multiple choice answers, using a reserved word in an answer makes the testit() crash with a not helpful message (at least for me).

I can see that you are in the midst of redoing the testing and testit() is deprecated so I'm a bit hesitant to send a PR, but will try to solve if you want me to. It's a bit of a tricky issue because really something that happens in Swirl not Swirlify, but I feel as though Swirlify should catch it more gracefully if possible.

added: Maybe I should submit something about this to the swirl course gotcha lesson?

seankross commented 8 years ago

Does the same thing happen when using demo_lesson()?

elinw commented 8 years ago

No, it seems to work fine in demo_lesson().

Actually I was using the CRAN version, but in the github version it seems not to be an issue.

seankross commented 8 years ago

That's interesting, the CRAN version and the master branch on Github should be identical.

elinw commented 8 years ago

Maybe I had an older version?

seankross commented 8 years ago

What do you get as the result of packageVersion("swirlify")?

elinw commented 8 years ago

Well now I have ‘0.5.0’.

I’m not sure what I had before I did github_install(). Okay that's just weird, will update again.

On Aug 13, 2016, at 4:50 PM, Sean Kross notifications@github.com wrote:

packageVersion("swirlify")

seankross commented 8 years ago

Okay, sounds good. I'm going to close this issue, but feel free to reopen it if you have any other issues.