search

swirldev / swirlify

:books: A toolbox for writing swirl courses
Other
63 stars 47 forks source link

file.rename() versus file.copy() #22

Closed elinw closed 8 years ago

elinw commented 8 years ago

Hi Sean, I see that in most of the install functions file.rename() is used instead of file.copy(). This means that the existing course needs to be uninstalled before installing an updated version (if an update option was added). Admittedly you would also have to do file.remove to clean up the first unzipped copy but for me, as I'm adding lessons to the server, it would be preferable not to have to uninstall. If you agree, I'd be happy to send a PR for this change.

seankross commented 8 years ago

I agree with you, I need to look at this more closely.

seankross commented 8 years ago

Does this have anything to do with the manifest? (Asking because of issue title)

elinw commented 8 years ago

No, sorry, I started something about the manifest and then realized it was actually fixed in master. I actually changed the title.

Elin

On Aug 1, 2016, at 3:19 PM, Sean Kross notifications@github.com wrote:

Does this have anything to do with the manifest? (Asking because of issue title)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/swirldev/swirlify/issues/22#issuecomment-236679465, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEfc_NFREZacCar6GHwL_T8DWXnEv3ks5qbkbagaJpZM4JZrgB.

elinw commented 8 years ago

I'm going to close this because it is really a bug in swirl and not in swirlify.