search

swisnl / jQuery-contextMenu

jQuery contextMenu plugin & polyfill
https://swisnl.github.io/jQuery-contextMenu/
MIT License
2.24k stars 744 forks source link

Fontawesome 5 (Pro?) support broken #638

Closed reFX-Mike closed 6 years ago

reFX-Mike commented 6 years ago

When using the CSS/webfont for FontAwesome 5.0 (I've used Pro, but it might affect the non-pro version as well), the icons do not show up at all.

I've managed to supply a function that returns the correct class names, but then the icons have a large margin/padding on the left and the menu-item text itself loses its font and looks like some old school font with sarifs.

LeonGreeff commented 6 years ago

I have the same issue. I will come back to you if I have found a solution.

bbrala commented 6 years ago

I wonder what the best solution would be. The current setup is really just adding an class to the item.

Perhaps the best option would be another icon setting (iconHtml?) in which you can put a bit of html. Which enables things like <i class='fas fas-confirm'></i>. And would enable usage of different icons. Especially since Fa5 now also supplies SVG alongside the old font approach.

wimZ commented 6 years ago

Same issue here. The fa icons show huge.

Fontawesome has a shim js, but that does not solve it.

Fal;ling back to native icons for now

dschueler commented 6 years ago

same here...FA BROKEN ..all good in the rest of my page..NOT good in context menu

2018-06-23_08-41-31

BrennickL commented 6 years ago

We recently upgraded to FontAwesome 5 Pro and all Icons are broken. As mentioned above the icon sets for fa, fal, and fab icons are no longer displaying. Unable to fallback to previous version of FontAwesome. Looking for a work-around to fix the problem.

bbrala commented 6 years ago

This issue is is a duplicatie of #593, i've created a branch with a fix for Font Awesome 5 support.