Add extra verifications for links - Githubissues

swisnl / json-api-client

A PHP package for mapping remote {json:api} resources to Eloquent like models and collections.

MIT License

205 stars 24 forks source link

Add extra verifications for links #59

Closed JaZo closed 5 years ago

JaZo commented 5 years ago

Description

Self and related links can no longer be null.
Some links objects MUST now have certain links if a links object is present: Error: about Relationship: self or related

Motivation and context

According to the spec, self and related links can not be null, only pagination links can be.

Spec for error: https://jsonapi.org/format/#error-objects Spec for relationship: https://jsonapi.org/format/#document-resource-object-relationships

How has this been tested?

Tested with new and updated unit tests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[x] I have added tests to cover my changes.
[x] If my change requires a change to the documentation, I have updated it accordingly.