swisnl / json-api-client

A PHP package for mapping remote {json:api} resources to Eloquent like models and collections.
MIT License
205 stars 24 forks source link

Include `jenssegers/model` as `Swis\JsonApi\Client\Model` #87

Closed bbrala closed 3 years ago

bbrala commented 3 years ago

Description

Included jenssegers/model as Swis\JsonApi\Client\Model with tests.

Motivation and context

jenssegers/model doesn't receive much love from its maintainer. Besides, it requires illuminate/support and efforts to remove this dependency are ignored; jenssegers/model#37

Marked as breaking change since it changes the root dependencies.

How has this been tested?

Tested with Unit Tests. The public API should be the same since we already used an Item class for the model instances.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.