search

swisnl / json-api-client

A PHP package for mapping remote {json:api} resources to Eloquent like models and collections.
MIT License
205 stars 24 forks source link

ParamNameMismatch #96

Closed NorthenIrbis closed 2 years ago

NorthenIrbis commented 2 years ago

The class Item uses a trait src/Concerns/HasRelations.php and implements an interface src/Interfaces/ItemInterface.php. the parametersname in method setRelation of HasRelation dont match with method setRelation of ItemInterface.

You might read in https://psalm.dev/docs/running_psalm/issues/ParamNameMismatch/ about it.

I suggest to rename parameters` name in method setRelation in classes which implements ItemInterface.

JaZo commented 2 years ago

Thanks, fixed in d20c349!

NorthenIrbis commented 2 years ago

Not at all! Thank you too! )