swisnl / json-api-server

Set up a JSON API in Laravel in just a few minutes.
MIT License
105 stars 19 forks source link

Inconsistent HTTP methods #14

Closed liepumartins closed 6 years ago

liepumartins commented 6 years ago

Routes define patch method https://github.com/swisnl/json-api-server/blob/906609f48492b0dad050403c36567c078da3759b/resources/templates/route.stub#L10

Tests tries to use put method, which is not defined https://github.com/swisnl/json-api-server/blob/906609f48492b0dad050403c36567c078da3759b/resources/templates/authentication_test.stub#L54

Which is the correct one?

bbrala commented 6 years ago

I've double-checked the specification, and I would prefer PATCH since that is the request the specification uses.