swisnl / openapi-spec-generator

Creates Open API spec for a Laravel JSON:API
Apache License 2.0
23 stars 11 forks source link

Add support for Laravel 11 #19

Closed pjotrvdh closed 6 months ago

pjotrvdh commented 6 months ago

Description

This pull request updates the version numbers in the composer.json file to reflect the latest stable releases of the dependencies.

Motivation and context

I was updating a project to Laravel 11 and was unable to because of missing versions.

How has this been tested?

I was able to successfully update my project

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

tommie1001 commented 6 months ago

@JaZo wellicht kunnen we 7.4 weghalen met een nieuwe versie?

JaZo commented 6 months ago

@JaZo wellicht kunnen we 7.4 weghalen met een nieuwe versie?

The tests for 8.2 and 8.3 were failing, so that wasn't the problem. Although I'm okay with removing support for 7.4 if it's blocking.

tommie1001 commented 6 months ago

Perhaps not blocking, but I think its better to release new versions for the current supported php versions instead of giving support for unsupported php versions

JaZo commented 6 months ago

As long as it doesn't get in our way I usually leave it so we don't force anyone to update, but if it gets in the way at all I remove it immediately. @Rocksheep is working on a new feature that requires PHP 8 features (https://github.com/swisnl/openapi-spec-generator/pull/18), so he removed 7.4 support there. So eventually support will be dropped.