Closed Gaetan-cogliati closed 5 months ago
Some more comments:
Elements to improve, add or fix:
Looks okay to me.
I see some warning in the frontend section though. I don't know if these are related to this PR or if that's an older issue:
WARNING in [eslint]
frontend | src/components/FilterDrawer/FilterDrawer.tsx
frontend | Line 63:11: 'MaterialUISwitch' is assigned a value but never used @typescript-eslint/no-unused-vars
frontend | Line 99:11: 'CustomSwitch' is assigned a value but never used @typescript-eslint/no-unused-vars
frontend |
frontend | src/pages/PipelineEditor/index.tsx
frontend | Line 614:8: React Hook React.useEffect has a missing dependency: 'onEdgeDelete'. Either include it or remove the dependency array react-hooks/exhaustive-deps
Also some deprecation warnings:
(node:37) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
frontend | (Use `node --trace-deprecation ...` to show where the warning was created)
frontend | (node:37) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Interactive pipeline creation feature