swiss-art-research-net / rdmi

Reference Data Model Implementation
2 stars 0 forks source link

data transformation for person not language aware #5

Closed thomashaensli closed 4 years ago

thomashaensli commented 4 years ago

Hi Nikos.

just checked on the latest data (as of now). I see that the appellation and description (short) are displayed in all four languages though they are the same. Can we do something about it?

See https://rds-dev.swissartresearch.net/resource/?uri=http%3A%2F%2Fgrp.swissartresearch.net%2Fperson%2F49BC8316-FB50-43B3-92BB-09245221E2CC

MinadakisNikos commented 4 years ago

Hi Thomas, I mentioned in our call that I did this on purpose to test the visualization compinations (since there is only one language value for this record). It will not be there after the refinement.

ncarboni commented 4 years ago

Still on, I will add to the "LODLAM todo" milestone

MinadakisNikos commented 4 years ago

Test it. Solved.

ncarboni commented 4 years ago

@MinadakisNikos seems to appear in the instance of Places. For example.

MinadakisNikos commented 4 years ago

Ok the ticket was only for persons so I did not look at places. It is solved now

On Fri, 24 Jan 2020 at 13:15, Nicola Carboni notifications@github.com wrote:

@MinadakisNikos https://github.com/MinadakisNikos seems to appear in the instance of Places example https://rds-dev.swissartresearch.net/resource/?uri=http%3A%2F%2Fresource.swissartresearch.net%2Fplace%2FF49B2EDD-4D0A-4E02-839A-AE09CB876820

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/swiss-art-research-net/rdmi/issues/5?email_source=notifications&email_token=ADXWR2X4ITY4PE77OKSC3JDQ7LEVJA5CNFSM4I7KOTD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ2PCWA#issuecomment-578089304, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXWR2TZ5IGNKXNMSA7WSN3Q7LEVJANCNFSM4I7KOTDQ .

ncarboni commented 4 years ago

Last (sorry, noticed now). Also the parent place (P89) for places have the same issue. Example here

MinadakisNikos commented 4 years ago

Its not the same issue. This is another phenomenon because germany has two URIs one with the UUID coming from you and another one with the tgn id. Maybe we should keep only one of these as a direct link.

On Fri, 24 Jan 2020 at 13:25, Nicola Carboni notifications@github.com wrote:

Last (sorry, noticed now). Also the parent place (P89) for places have the same issue. Example here https://rds-dev.swissartresearch.net/resource/?uri=http%3A%2F%2Fresource.swissartresearch.net%2Fplace%2F4793FC72-5C5E-4968-9A93-F9ADF7162B14

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/swiss-art-research-net/rdmi/issues/5?email_source=notifications&email_token=ADXWR2XKQ33NB54JU3Y5NB3Q7LFZVA5CNFSM4I7KOTD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ2P22I#issuecomment-578092393, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXWR2QAHOIHGGUIVKZDIMLQ7LFZVANCNFSM4I7KOTDQ .

ncarboni commented 4 years ago

To review mappings @ncarboni

ncarboni commented 4 years ago

Two identified problem in the call of 31 Jan 2020:

@MinadakisNikos @ymark

MinadakisNikos commented 4 years ago

Fixed. Test please

ncarboni commented 4 years ago

great 👍