Missing Formation and dissolution in the modelling of groups

ncarboni commented 4 years ago

Missing the modelling of

_02_actor_existence_birthDate_p82a
_02_actor_existence_birthDate_p82b
_02_actor_existence_deathDate_p82a
_02_actor_existence_deathDate_p82b

ncarboni commented 4 years ago

Should be mapped using the patterns from here

https://docs.swissartresearch.net/et/group/#existence (formation and dissolution)

MinadakisNikos commented 4 years ago

Was already done. Please check again.

ncarboni commented 4 years ago

I cannot see it in the current data, nor in the current mapping of groups (the newer one). I checked and the records are present in the transformed XML.

Example: https://rds-dev.swissartresearch.net/resource/?uri=https://resource.swissartresearch.net/group/C9CB7819-714F-4C89-BC4C-0C77EFF97599 present the value

<_02_actor_existence_birthDate_p82a>1937-01-01</_02_actor_existence_birthDate_p82a>
<_02_actor_existence_birthDate_p82b>1937-12-31</_02_actor_existence_birthDate_p82b>
<_02_actor_existence_deathDate_p82a>2009-01-01</_02_actor_existence_deathDate_p82a>
<_02_actor_existence_deathDate_p82b>2009-12-31</_02_actor_existence_deathDate_p82b>

But not in RDF (unless I am missing something)

ncarboni commented 4 years ago

Found the issue(s). It is present only _02_actor_existence_deathDate_p81a/b and _02_actor_existence_birthDate_p81a/b and both they were mapped using the property P82a/b plus use of xsd:date instead of xsd:datetime.

Added

_02_actor_existence_deathDate_p82a/b
_02_actor_existence_birthDate_p82a/b

Changed

the mapping of deathDate P81a/b accordingly to the label of the field
the mapping of birthDate P81a/b accordingly to the label of the field
if exists statements for all the P81/P82 a/b
if statements in relation to uncertainty in order to not create E66 formation even when not needed.
corrected the URI for dissolution in order to reflect the event (they were saying formation).

Moreover,

The uri schema currently present the URI of formation and dissolution as

https://resource.swissartresearch.net/formation_timespan/{UUID} https://resource.swissartresearch.net/dissolution_timespan/{UUID}

not coherently with the rest of the URI used until now.

In order to be consistent I added in the generator and tested with:

<generator name="groupDissolutionTimespan" prefix="sari">
    <pattern>group/{group_id}/dissolution/timespan</pattern>
</generator>

<generator name="groupFormationTimespan" prefix="sari">
    <pattern>group/{group_id}/formation/timespan</pattern>
</generator>

which results in

https://resource.swissartresearch.net/group/9E0E3DD6-26DF-419B-A4AB-9B46F0FACDEA/formation/timespan https://resource.swissartresearch.net/group/9E0E3DD6-26DF-419B-A4AB-9B46F0FACDEA/dissolution/timespan

If there are no problems I would go for groupDissolutionTimespan and groupFormationTimespan for the uri. Do you foresee any problem with going with the new uri? @MinadakisNikos @ymark

If there are no problem I will upload the newly modified X3ML with groupDissolutionTimespan and groupFormationTimespan

I added both modifications as

mappings-Group_mod_old_uri
mappings-Group_mod_new_uri in https://github.com/swiss-art-research-net/rdmi/tree/master/3M_Mapping/Reference_data_model_mapping/smartup

ncarboni commented 4 years ago

To be verified in the new data

swiss-art-research-net / rdmi

Missing Formation and dissolution in the modelling of groups #53