Missing mapping of fullbio for entity person

ncarboni commented 4 years ago

The field _05_actor_documentation_fullbio_de has not been mapped in the X3ML. The value are missing.

Should be added and distinguish from the short by using the types

crm:P2_has_type http://vocab.getty.edu/aat/300055908
crm:P2_has_type "Long Biography"

MinadakisNikos commented 4 years ago

Done. Please Check

ncarboni commented 4 years ago

Great. Uploaded on github and changed this https://github.com/swiss-art-research-net/rdmi/blob/3b2461584dd03697325f43b82958dffaa28ab410/3M_Mapping/Reference_data_model_mapping/smartup/mappings-Person.x3ml#L864 On both fullbio_en and fullbio_de

Probably is better to keep the mapping in sync on git, in order to visualise and comment always the last version. Open another issue for the same problems in groups

ncarboni commented 4 years ago

verified but further problem with the use of uuid

https://github.com/swiss-art-research-net/rdmi/blob/d85dd29eb50f36b874f8fea95e250c69f17a8b98/3M_Mapping/Reference_data_model_mapping/smartup/generator-policy.xml#L59-L62

The problem I foresee here is that is going to change every time and pointing at it it is going to be hard. Did you use this to differentiate between long and short of for other reasons? why not two generators (short and long):

<generator name="shortPersonBiography" prefix="sari">
    <pattern>person/{person_id}/biography/short/{lang}/</pattern>
</generator>

<generator name="longPersonBiography" prefix="sari">
    <pattern>person/{person_id}/biography/long/{lang}/</pattern>
</generator>

? Same of course for groups

ncarboni commented 3 years ago

To be verified in the new data

swiss-art-research-net / rdmi

Missing mapping of fullbio for entity person #60