swiss-seismological-service / DUGseis

Software for acquisition and processing of micro-seismic data
Other
9 stars 4 forks source link

JOSS Review: Paper questions #11

Closed erexer closed 2 weeks ago

erexer commented 1 month ago

This is for the JOSS Review.

typos/grammar

I'd recommend running the paper through a grammar checker.

mrosskopf commented 1 month ago

Hi, thank you for your suggestions. I adjusted the text and also ran it through a grammar checker again. I changed the event that was displayed in Figure 2. The one displayed now is just a few hours later, but the waveforms and channel information are already on zenodo. To open it in GUI, you can use the yaml file (just change the paths) and the sqlite file I now provided in the paper folder of the repository, plus the given waveform and channel information from zenodo. Are there any other suggestions to this topic? :)

erexer commented 1 month ago

Thanks! Could you add GMuG as a citation and make it clear in Figure 2 that the data comes from Rosskopf et al. 2024 (put it in the caption).

mrosskopf commented 1 month ago

Hi, I slightly changed the text to not include a citation in the summary section but I added the website of GMuG and of another software in the section "Statement of need" after slightly changing the text. The software itself do not have a direct citation, but I hope it is fine with the websites. I also added the data citation in the caption.

erexer commented 1 month ago

You need a comma at the end of this line so that the paper will render correctly :)

mrosskopf commented 1 month ago

Ah yes, of course! Sorry about that.

erexer commented 3 weeks ago

Thanks for bearing through this with me! There's still some grammar errors in the paper, for example, when I run the abstract through this grammar checker, it points out:

mrosskopf commented 3 weeks ago

I hope I corrected all errors now. I already used your suggested grammar checker in the past, but only the free version. I tried different ones again and hope they fix all the grammar mistakes.

mrosskopf commented 3 weeks ago

For your information - I just updated the paper again since it was now corrected by a professional proofreader.

erexer commented 2 weeks ago

Looks great!