swiss-seismological-service / SeismoStats

https://seismostats.readthedocs.io
GNU Affero General Public License v3.0
7 stars 3 forks source link

seismostats.seismicity: find a better name #161

Closed aronsho closed 2 months ago

aronsho commented 3 months ago
schmidni commented 3 months ago

Let's call it "catalogs", as we call all the data structures some kind of "**Catalog".

I will implement it as soon as @martahan FINALLY implemented the tests, so that we don't have a major merge conflict.

aronsho commented 3 months ago

Idea: Have two modules, seismostats.catalogs and seismostats.rategrid They are esssential, they deserve it :)

schmidni commented 3 months ago

yes they have their own module, but I'm against making two separate packages each with only one module inside.

aronsho commented 3 months ago

How about structures? That would be fitting for both catalog and rategrid

schmidni commented 2 months ago

@aronsho In the end, we import them from the seismostats root-package directly anyways, so it is really just internally that we need to know what it is, and I think catalogs is good enough. Structures isn't bad, but not really a word that is used in this context, so I think catalogs is easier to understand.

@martahan you've worn out my patience, good luck with the merges.