search

swiss-seismological-service / scdetect

A computationally efficient earthquake detection module for SeisComP
https://scdetect.readthedocs.io
GNU Affero General Public License v3.0
15 stars 6 forks source link

typo in scdetect-cc for Dummies -- screen results --record-url? #123

Closed funkes closed 2 years ago

funkes commented 2 years ago

To show seismograms by scolv (topic scdetect-cc for Dummies -- Offline Playback -- examples ex-02 & ex-03 -- screen results) I changed the option "--record-url" of scolv from

"fdsnws://eida-federator.ethz.ch/fdsnws/dataselect/1/query"

to

"fdsnws://eida.ethz.ch".

Probably the very useful documentation [1] contains a typo?

[1] https://scdetect.readthedocs.io/en/stable/base/SCDetect-for-Dummies.html#offline-playback

damb commented 2 years ago

Thanks for reporting.

Technically, the eidaws-federator URL should work, as well. The required MSEED data shouldn't have restricted access permissions and therefore should be accessible.

Though, for the sake of consistency we may switch to ETHZ's fdsnws-dataselect endpoint URL. @mmesim, any strong opinions against switching?

mmesim commented 2 years ago

Though, for the sake of consistency we may switch to ETHZ's fdsnws-dataselect endpoint URL. @mmesim, any strong opinions against switching?

No, please go ahead. Thanks @funkes for reporting.

damb commented 2 years ago

@funkes, could you please provide a PR? Thanks.

funkes commented 2 years ago

See branch "patch-1"; hopefully it meets your suggestions?!

Sorry for my hesitance, but it was my first PR on GIT. So I'm not sure, whether I've found a proper way.

Are explicite hints to the related issues (#122, #123) useful?