search

swiss-seismological-service / scdetect

A computationally efficient earthquake detection module for SeisComP
https://scdetect.readthedocs.io
GNU Affero General Public License v3.0
15 stars 6 forks source link

Phase association issue (regression) #125

Closed mmesim closed 2 years ago

mmesim commented 2 years ago

Well, I was testing feature/iss-118 when I noticed something weird. When I run scdetect-cc on multiple stations & multiple channels and setting the minimumArrivals to 8 (for example) in the template.json, the code returns all possible detections and ignores completely this value. Same when I run scdetect-cc on master.

Then I tried to set the value in the module (scconfig) and I got this

15:36:07 [error/DETECT] Invalid configuration: 'minimumArrivals': 8. Must be < 0 or >= 1
Try --help for help

I pulled today the most recent master from seiscomp github page, but I have no idea if this issue is related to that.

mmesim commented 2 years ago

The issue is definitely related to scdetect-cc and the current master branch.

I ran a few examples with an older version of scdetect-cc and it worked fine. However I still get the same error when trying to fix minimumArrivals in scconfig.

When I switched to the latest master the minimumArivals set in templates.json is ignored.

mmesim commented 2 years ago

input.files.zip

In the zip you can find all the input files and the expected results. It is actually the input files from example-03.

damb commented 2 years ago

Perfect, @mmesim. Thanks a lot.

damb commented 2 years ago

A minor note.

When I switched to the latest master the MinimumArivals set in templates.json is ignored.

Please make sure the spelling of the configuration parameters is correct. E.g. instead of MinimumArrivals it must be minimumArrivals in the templates.json. See also: https://scdetect.readthedocs.io/en/stable/base/Template-Configuration.html#detector-configuration-parameters.

In the templates.json unknown configuration parameters are simply ignored.

mmesim commented 2 years ago

Please make sure the spelling of the configuration parameters is correct. E.g. instead of MinimumArrivals it must be minimumArrivals in the templates.json. See also: https://scdetect.readthedocs.io/en/stable/base/Template-Configuration.html#detector-configuration-parameters.

In the templates.json unknown configuration parameters are simply ignored.

I confirm that I misspelled minimumArrivals here. The .json file is fine.

damb commented 2 years ago

Actually, there were two issues: