Fix phase association - Githubissues

swiss-seismological-service / scdetect

A computationally efficient earthquake detection module for SeisComP

https://scdetect.readthedocs.io

GNU Affero General Public License v3.0

15 stars 6 forks source link

Fix phase association #126

Closed damb closed 2 years ago

damb commented 2 years ago

Bugfixes:

Fix phase association. Actually, this is a regression introduced with a1d8ce843ac81a09b82cc4930fc60a7ca639a80f.
Fix default minimumArrivals module configuration parameter validation.

Closes #125.

damb commented 2 years ago

@mmesim, I checked the results visually by means of scolv. Could you check on your side, as well (to make sure that things are working properly now)? Thanks.

damb commented 2 years ago

Besides, it would be good to add ex-03 to the test suite. Perhaps it would be sufficient to use 10-20min of the data. Just to avoid another regression.

mmesim commented 2 years ago

@mmesim, I checked the results visually by means of scolv. Could you check on your side, as well (to make sure that >things are working properly now)? Thanks.

Checked and works fine. Thanks a lot.

PS. I checked the ex-03 with the data I sent you and it is ok. Perhaps you can add that to the test suite. :swimmer:

damb commented 2 years ago

Due to #129 and #130 at the time being it doesn't seem sensible to add ex-03 to the test suite. Instead I'll merge this one. The test suite should include the ex-03 test case once both #129 and #130 are fixed.