search

swiss-seismological-service / scdetect

A computationally efficient earthquake detection module for SeisComP
https://scdetect.readthedocs.io
GNU Affero General Public License v3.0
15 stars 6 forks source link

Compile Source Code in SeisComPv6 #144

Closed akasa-denada closed 4 months ago

akasa-denada commented 4 months ago

Currently, I want to compile scdetect but I got error message like this. Can you help me?

image
luca-s commented 4 months ago

Thanks for reporting the issue. We haven't switched to SeisComP 6 yet so we haven't noticed this compilation issue yet. Let me fix this and I will be back to you.

akasa-denada commented 4 months ago

Thank you, Luca. I will wait for it.

luca-s commented 4 months ago

If I compile the seiscomp v6 branch the code compiles fine. Are you compiling the master branch of seiscomp @akasa-denada ?

akasa-denada commented 4 months ago

Yes, I compile with seiscomp v6.3.1. The folder scdetect put in src/extra right? The compile is well only with scrtdd.

luca-s commented 4 months ago

The folder scdetect put in src/extra right?

Yes

Yes, I compile with seiscomp v6.3.1.

So you mean "No", you don't compile the master branch. Because the seiscomp v6.3.1 is in the branch v6 not the master. could you confirm please?

akasa-denada commented 4 months ago

Yes, I mean compile with the master branch

luca-s commented 4 months ago

Ok now i understand. I tried compiling the master branch of seiscomp and I get the same error as you.

However, unless you have a valid reason for it, you should not compile the master branch. Each seiscomp version has a dedicated git branch (v4, v5, v6 ..) and a specific git tag for each released version (5.5.9, 6.0.0, 6.0.1, ...). If you intend to compile seiscomp 6 you should use branch v6. The master branch is a development branch that contains breaking changes and changes intended for the next major release of seiscomp (e.g. seiscomp 7). This is why you see this compilation error. If you compile the v6 branch all works fine and you are also guaranteed that the code is compatible with seiscomp 6 (e.g. database schema, but also API in case you install proprietary modules like scanloc).

So my suggestion is to checkout branch v6 and recompile. That said, I need to fix the compilation issue anyway, because the master branch will become a new seiscomp version eventually. So I will provide a commit anyway.

Please let me know if my comment makes sense or if my explanation is not clear.

luca-s commented 4 months ago

I pushed a commit and scdetect should now compile on master branch of seiscomp as well.

akasa-denada commented 4 months ago

Ok now i understand. I tried compiling the master branch of seiscomp and I get the same error as you.

However, unless you have a valid reason for it, you should not compile the master branch. Each seiscomp version has a dedicated git branch (v4, v5, v6 ..) and a specific git tag for each released version (5.5.9, 6.0.0, 6.0.1, ...). If you intend to compile seiscomp 6 you should use branch v6. The master branch is a development branch that contains breaking changes and changes intended for the next major release of seiscomp (e.g. seiscomp 7). This is why you see this compilation error. If you compile the v6 branch all works fine and you are also guaranteed that the code is compatible with seiscomp 6 (e.g. database schema, but also API in case you install proprietary modules like scanloc).

So my suggestion is to checkout branch v6 and recompile. That said, I need to fix the compilation issue anyway, because the master branch will become a new seiscomp version eventually. So I will provide a commit anyway.

Please let me know if my comment makes sense or if my explanation is not clear.

Thank you, Luca. I just tried it and it worked.

luca-s commented 4 months ago

All good then. I am closing this.