swiss-seismological-service / scdetect

A computationally efficient earthquake detection module for SeisComP
https://scdetect.readthedocs.io
GNU Affero General Public License v3.0
15 stars 6 forks source link

ENH: resampling functionalities is now applying anti-alias filter #23

Closed luca-s closed 3 years ago

luca-s commented 3 years ago

Reference: http://www.nicholson.com/rhn/dsp.html

damb commented 3 years ago

@luca-s, thanks for the PR.

luca-s commented 3 years ago
* May I ask why you decided to implement the lowpass filter by yourself? Is there a reason why you didn't fall back to `BW_LP(order, hi-freq)` from https://docs.gempa.de/seiscomp/4/4.0.2/base/filter-grammar.html for the anti-alias filter?

I wanted something specific for resampling and faster. Have you thought on how you would use the BW_LP in the code?

* What about implementing unittests?

If you find the time to do so, I will borrow your code ;)