Fix `MRelative` magnitude calculation

swiss-seismological-service / scdetect

A computationally efficient earthquake detection module for SeisComP

https://scdetect.readthedocs.io

GNU Affero General Public License v3.0

15 stars 6 forks source link

Closed damb closed 2 years ago

damb commented 2 years ago

Bugfixes:

compute absolute values client-side; the bug was caused due to a misunderstanding of SeisComP API of NumericArray<T>::absMax() (see https://github.com/SeisComP/common/blob/399d98c2d709f24ecf0f4bc27f759cefa76dc2f3/libs/seiscomp/core/typedarray.cpp#L425-L428)

Thanks @mmesim for spotting this.

damb commented 2 years ago

@mmesim, could you check if the issue is fixed on your side? Thanks.

damb commented 2 years ago

@mmesim, if compiling make sure you're using the most recent SeisComP upstream. This is required due to upstream API changes.

mmesim commented 2 years ago

Alles gut!

Go ahead with the merge. @damb Great job! :+1: