swiss / styleguide

admin.ch styleguide
https://swiss.github.io/styleguide
MIT License
124 stars 37 forks source link

JavaScript warnings from vanilla vendor.min.js #530

Open cstuder opened 7 years ago

cstuder commented 7 years ago

When using the vanilla vendor.min.js from the 3.0.0 download, warnings appear in the console:

On Firefox 53:

Ein Aufruf von document.write() durch ein asynchron geladenes externes Skript wurde ignoriert.  vendors.min.js:8:2661
getPreventDefault() sollte nicht mehr verwendet werden. Verwenden Sie stattdessen defaultPrevented.  vendors.min.js:2:26643

On Chrome 58:

Failed to execute 'write' on 'Document': It isn't possible to write into a document from an asynchronously-loaded external script unless it is explicitly opened.   vendors.min.js:8

Warnings don't appear in Internet Explorer 11.

Functionality doesn't seem to be impaired.

(On a related note: There doesn't seem to be any documentation what's inside of vendor.min.js outside of the Gulp-file.)

bihorco36 commented 6 years ago

When I check the console without adding any new external libraries this error does not appear. I think this is a vanilla.js or another third party library issue of your project. This Error just occurs in the vendor.mini.js file because most of the library sources are there included (including your vanilla.js). In the gulpfile.js > "Build vendors dependencies" section you can check which libraries are included for your project.

@almeidap could you please look at this issue?