search

swiss / styleguide

admin.ch styleguide
https://swiss.github.io/styleguide
MIT License
123 stars 36 forks source link

Horizontal padding reset #642

Open fkm opened 6 years ago

fkm commented 6 years ago

https://github.com/swiss/styleguide/blob/45603d74b3479883104f47324b6eb83bd0a83b8d/src/assets/sass/layout/forms.scss#L94

Why is the horizontal padding reset on has-error? Is there any specific reason?

IMO this should be:

padding-top: 6px;
padding-bottom: 6px;
gillerr commented 4 years ago

Will be solved with Material Design migration Issue will be closed

fkm commented 4 years ago

I just hope you'll do a better job with the Material Design implementation than you did with Bootstrap.