swiss / styleguide

admin.ch styleguide
https://swiss.github.io/styleguide
MIT License
123 stars 36 forks source link

Missing heading class #643

Closed fkm closed 4 years ago

fkm commented 6 years ago

https://github.com/swiss/styleguide/blob/45603d74b3479883104f47324b6eb83bd0a83b8d/src/assets/sass/layout/titles.scss#L16

As this style guide is based on Bootstrap, all your heading definitions should (must?) include the respective classes.

Here, we need .h4 in addition to h4.

Docs: https://getbootstrap.com/docs/3.3/css/#type-headings

gillerr commented 4 years ago

No, both options yields the same result, they are not meant to be used together. Anyway, this will be solved with the migration to Material Design Issue will be closed

fkm commented 4 years ago

I just hope you'll do a better job with the Material Design implementation than you did with Bootstrap.