search

swissbib / vufind

A library resource discovery portal designed and developed for libraries by libraries
GNU General Public License v2.0
12 stars 7 forks source link

npm run build fails with autosuggest.ts #675

Closed liowalter closed 5 years ago

liowalter commented 5 years ago

Travis fails with npm run build :

To reproduce locally :

The problem is with this line https://github.com/swissbib/vufind/blob/master/themes/sbvfrd/ts/autosuggest/AutoSuggest.ts#L248

ERROR in ./themes/sbvfrd/ts/autosuggest/AutoSuggest.ts [tsl] ERROR in /usr/local/vufind/httpd/themes/sbvfrd/ts/autosuggest/AutoSuggest.ts(248,40) TS2339: Property 'target' does not exist on type 'Event'.

Until December 7th it worked. Maybe it is related to this https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration.

As we don't use autosuggest right now, this shouldn't affect the users.

My PHPStorm also displays this error.

edelm commented 5 years ago

Looks like the @types/jquery npm-package changed: https://www.npmjs.com/package/@types/jquery/v/3.3.27

In https://github.com/swissbib/vufind/blob/master/tsconfig.json#L16 we include the file "node_modules/@types/jquery/index.d.ts" which contained the definition of the Event interface. When we remove the node_modules and reinstall them, the definition of the interface is in ''node_modules/@types/jquery/misc.d.ts".

Changing the include in tsconfig.json to the didn't seem to fix it, though. I will spend more time on that later...

edelm commented 5 years ago

fixed by 867bc560cf52bd95383401d7205ba3c806681b7b